[MERGE] per-user file properties

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ian Clatworthy wrote:
| Jelmer Vernooij wrote:
|> Hi Ian,
|
|> I haven't done any code review but a quick comment nonetheless;
|> I'd rather see a different filename than $BAZAAR_HOME/.bzrproperties.
|> Using a dot file doesn't make sense in this case since it is
|> inconsistent with the names of all other files in BAZAAR_HOME and it
|> makes it hard to discover the file.
|
| I'm pretty sure .bzrignore is supported within BAZAAR_HOME and I was
| trying to be consistent with that name. If we do decide to let users
| define properties in their working tree, then making things as similar
| as we can to what we do for .bzrignore seems sensible to me.
|
| FWIW, the equivalent file in git is called .gitattributes. To my
| (limited) knowledge, other VCS tools pretty much all support .xxxignore
| file but don't support .xxxproperties or .xxxattributes files, so
| there's really no "standard" I know of that users would expect us to follow.
|
| Ian C.
|
|

I'm trying to understand what you are calling BAZAAR_HOME. As the string
'BAZAAR_HOME' doesn't exist in the source code.

Are you trying to say "$BZR_HOME" which is equivalent to $HOME.

I would certainly put it into bzrlib.config.config_dir() + 'fileproperties'

That puts it under ~/.bazaar/fileproperties
which is right next to ~/.bazaar/ignore
the per-user ignore file.

If you are looking to put it in the source tree itself, then I think
'.bzrproperties' is perfectly reasonable. But we have a whole . directory for
files in ~/.bazaar, no reason to keep ~/.bzr*** as well. (Which is something we
should have done for ~/.bazaar/log instead of ~/.bzr.log ...)

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkggVcEACgkQJdeBCYSNAAM/LwCeMYeAIp4y5plU4cs5YCRmd5ru
OG8An0Dm9fKt9hoD7UMdrYFBJEKfG5ie
=YRT9
-----END PGP SIGNATURE-----