[MERGE](trivial) deprecated_in should follow the same convention
John Arbash Meinel
john at arbash-meinel.com
Mon May 19 23:05:24 BST 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Martin Pool wrote:
| On Tue, May 20, 2008 at 6:57 AM, John Arbash Meinel
| <john at arbash-meinel.com> wrote:
|> All of the 'symbol_versioning.one_XXXX' strings end with a final '.'. This
|> patch
|> changes it so that 'deprecated_in((1, 6, 0))' also results in a final
|> period.
|>
|> I ran into this because I used deprecated_id((1, 6, 0)) in the source code,
|> and
|> then wanted to use "one_six" in the test suite. (For whatever reason.)
|>
|> Anyway, it made sense to have them output identical strings. I went ahead
|> and
|> submitted this because it is rather trivial.
|
| OK. But I was hoping that by adding this we could get away from
| needing to declare something like one_six in every release; the whole
| thing seems like unnecessary busywork.
|
| bb: approve
|
Well, I ended up not deprecating the function, so it is moot on my side as well.
I mostly did it for consistency. I understand your point about not creating a
"one_seven". Or possibly even using the "one_six" that we already have.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEUEARECAAYFAkgx+aQACgkQJdeBCYSNAAMQFQCXYzWb+zeTccwIR4m+i0seD4+3
VwCgoxT2eiFonrEqQCG5Cm1EQg+0cns=
=lGjo
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list