[MERGE/bzr-email] should_send does not always return a boolean anymore.

John Arbash Meinel john at arbash-meinel.com
Wed May 21 14:43:02 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
| On Wed, 2008-05-21 at 10:23 +0200, Vincent Ladeuil wrote:
|> Hi,
|>
|> Fixes some failing tests.
|
| What is should_send returning?
|
| -Rob

It is doing something like:

def should_send(self):

~  return self.to() or self.from_address()

which returns the actual string rather than a simple boolean. (It used to do:
return self.to() is not None and self.from_address() is not None

Which would obviously be a boolean, but fails if "to() == ''".

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkg0JuYACgkQJdeBCYSNAAMNMgCeLhNt+iLDISdcgT3JXvT8P+kR
zfIAn2Q/CjYFrrKAc25ALQp0UqLY6KGs
=76+A
-----END PGP SIGNATURE-----



More information about the bazaar mailing list