API breakages - file bugs / update HACKING.txt ?

Jelmer Vernooij jelmer at samba.org
Thu May 22 18:03:40 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Toshio Kuratomi wrote: | Martin Pool wrote:
>
> ...
>
> |> The first does not seem so practical: not adding new APIs during
>  that |> period would limit our development. |> | Err... Perhaps I
> could have been clearer.  API additions aren't the | problem.
> Removing of API, new mandatory arguments to methods, etc are. |  So
> you could add new API for six month and deprecate methods that they
>  | replace/need to get rid of in general.  And then have one
> release that's | a housecleaning release where incompatibilities
> saved up for six months | made.
>
> We rarely remove an API completely or add new mandatory arguments
> without deprecating. It is something I know I always look for in a
> review. I think what is hurting Jelmer is new non-mandatory
> arguments. Because the "client" code is supplying them, and since
> he overrode the function and doesn't have it... breakage.
It's not just new mandatory arguments., it's also public APIs
disappearing without deprecation. For example, the public constructor
of KnitVersionedFile lost two arguments in 1.4.

Thanks for your and Martins replies in this thread. In the future,
I'll just bring up breakages when I hit them so we can look at whether
it is feasible to add proper deprecation before the release.

Cheers,

Jelmer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQCVAwUBSDWnaAy0JeEGD2blAQJszQP/To4AnYy6op525LKOQhab75bYyV5yeLbF
5lRYwpMNC4d+osNRsVaL39oGSFNKBlT5Zir21/Pm5+VTfmzoRN57w7fZ6qKChOK3
dIU4ZQlyPLYjdn8/cErgh9VuwMlhMWbshsUR9Rxb7cHUk8BOMewnCMSPVWzYuvGO
9PHOSfWrFSY=
=OnBR
-----END PGP SIGNATURE-----




More information about the bazaar mailing list