[merge] errors in deleting obsolete packs should not be fatal (was Re: Problems with NFS mounted filestore)

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
| On Sun, May 25, 2008 at 6:57 PM, Russel Winder
| <russel.winder at concertant.com> wrote:
|> For reasons to do with "seeing the light" about how to use Bazaar as a
|> Subversion client (it took Jelmer a while to convince me, but he got
|> there in the end :-) I am taking a new branch of a Subversion repository
|> I already had a branch of.
|>
|> However, the branch consistently fails to work when run on a machine
|> which mounts the filestore over NFS.  I have just undertaken the branch
|> on the fileserver itself and that is fine.  I don't know if this is a
|> bzr or bzr-svn thing, nor whether it is a known issue, i.e. should I
|> report a bug?
|
| Thanks for the report.  This is a new bug.
|
| Could you please try merging this patch?
|
| The .nfs* files are NFS internal housekeeping for files that have been
| deleted by one client but that are still in use by another.  More
| generally, if we fail to delete one of these leftover files it
| shouldn't be considered a fatal error.  I think if the client(?)
| abruptly disconnects they can be left behind for a long time.
|
| Arguably we should just specifically ignore all .nfs* files.
|
|

The patch seems okay, though it may mean lots of 'delete()' calls for a Remote
transport which could do it in 1 call. (Then again, this sort of thing should be
a higher-level logical 'set-pack-names' sort of call anyway.)

BB:approve

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkg6tPIACgkQJdeBCYSNAAMAqACgwo2RF8UCpccb5Dc13MHjyrge
jOUAniHdPE44eUwMLcXJCB6MYDxQIEz4
=HCne
-----END PGP SIGNATURE-----