[RFC] Make diffstat work with bazaar 1.5

Russ Brown pickscrape at gmail.com
Mon Jun 2 16:31:25 BST 2008


Hi,

I'd appreciate a review of this since it's my first go at doing anything
with bzrlib. This diff gets the diffstat plugin working with bzr 1.5.

The crux of the issue was that diff_cmd_helper had been removed from
bzrlib. With some help from IRC I figured that show_diff_trees was what
it should be using instead. This lead to a number of other changes being required too.

Specifics that I think need reviewing are the uses of various functions
that obtain the trees to compare, and also how the revision number
parameters that are passed (if any) in are used. I've taken it to work
like this:

 * If no revision is given, show HEAD -> WC
 * If one revision is given, show REV -> WC
 * If two revisions are given, show REV1 -> REV2

Seems sensible to me, but others might not think so.

Thanks,
-- Russ

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1.5-compat-12.patch
Type: text/x-diff
Size: 5875 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080602/969937e0/attachment.bin 


More information about the bazaar mailing list