[MERGE] minor _build_tree clean-ups

John Arbash Meinel john at arbash-meinel.com
Mon Jun 9 02:23:34 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ian Clatworthy wrote:
| Some minor code improvements to transform._build_tree()
| attached.
|
| The only potentially controversial bit is the removal of
| an assertion. I maintain it isn't adding value because the
| following line will throw a good enough exception if
| that condition occurs.
|
| Ian C.
|

I'm not sure the specific need for 'entry.file_id => file_id', but it shouldn't
hurt anything. (And might make things a little faster without the extra
attribute lookups).

BB:approve

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkhMhhYACgkQJdeBCYSNAAP5SACgy5C7IuBpBCivRh2kpms+QOOH
fOsAoJ0Evhe7ArMrCOgsnt0uHITvvSdP
=6uB3
-----END PGP SIGNATURE-----



More information about the bazaar mailing list