[MERGE] (fixes 239523) bzr tag and other builtins respect --quiet

[Neil Martinsen-Burrell]

Aaron Bentley wrote:
> Neil Martinsen-Burrell wrote:
>> Since this doesn't change the signature of {Pull,Push}Result.report, I
>> haven't put it into NEWS.  Thanks for the architecture hints.  If it
>> wasn't for API stability, we could replace report(self, to_file) with
>> report(self, output_callable) and call the function as
>> pull_result.report(self.outf.write).
> 
> But we wouldn't want to, because then we wouldn't get the --quiet
> behavior.  Or do you mean we would just do trace.note directly?
> 
> I don't think we should do this:
> 
> +                    if not is_quiet():
> +                        result.report(self.outf)
> +                    else:
> +                        result.report(self.outf, note)
> 
> I think we should call result.report(self.outf, note) unconditionally.
> Our project policy is that notes, warnings and errors should all go to
> stderr, with stdout reserved for primary output.  (Commands like push,
> pull don't really have primary output.  Commands that have primary
> output include log, status, diff, etc.)
> 
> Is there a reason why you did it this way?

Just poor thinking.  Nice catch.  Fixed in attached.

-Neil

-- 
"The object of mathematics is the honor of the human spirit."
   -- Carl Jacobi
	
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: quiet-builtins.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20080623/fde377f3/attachment.diff