[MERGE] fix blackbox failures when run from windows executable

[Mark Hammond]

I've attached a new bundle which addresses all of your comments, although a couple of comments are worth making:

> filesystem.  I'm a little surprised that local_abspath is different to
> the realpath.  Is it just a \ vs. / issue?

As agreed, the patch now does .replace('/', os.path.sep).  Some of the lines are now a little long, but as other lines in that test file are roughly the same length I didn't bother splitting them.  I've also added a docstring patch for transport.local.local_abspath().

...
[re test_plugins]

> This change looks a bit weird, particularly how you set
> bzrlib.plugins.__path__
> to [] multiple times.  I think it's correct, but confusing.  I think if
> you extract the first determine the default builtin path section into a
> helper method it would be a little clearer.

Thinking more about it, that code was simply trying to get the builtin plugin path, which is always at the end of bzrlib.__path__ - so I simplified the test and added more comments about this.

Thanks,

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: windows_blackbox_failures.patch
Type: application/octet-stream
Size: 13832 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080811/7abc980b/attachment-0001.obj