[MERGE][1.6] Win32 regression fix for ENOTDIR handling

John Arbash Meinel john at arbash-meinel.com
Wed Aug 13 17:12:43 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This patch follows up on Mark Hammond's recommended patch for 1.6.
Basically, it adds a helper function for handling all the ways that
ENOTDIR gets raised on win32, as a workaround for os.listdir().

Python does a decent job of abstracting the OS when things work, it does
a rather poor job when things fail.

Ultimately I would like to unify this with the code in WorkingTree4
which also includes checks for ENOENT, but for now, I think this is
sufficient.

I am planning on getting this into 1.6, but I would like another
reviewer to approve it if possible.

I *can* say that doing "bzr rm file" fails without this patch, and
succeeds with it, so that part at least is correct.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkijB/sACgkQJdeBCYSNAANccwCeNjo50DQg7QH7ZKIDjUoXKEef
jQ0AnRJbl7tPUehX8/5F9mLAHO1GpsAF
=bwuB
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: win32_enotdir.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20080813/96859d90/attachment.diff 


More information about the bazaar mailing list