[MERGE][1.6][bug #259275] Disable automatic stacking via Bzrdir control.conf

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> However, I don't think we want people doing "bzr push lp:" to automatically
> have their branches and repositories upgraded to the latest format.

Agreed.

Let's be clear that we're talking about *new* branches and repos, not
existing ones.

> IMO, the appropriate fix is to have the "default_stack_on" config variable
> only respected when the source branch format supports it. And have this be
> true for both .sprout() and .clone().

I think this is sane.

> If the user explicitly supplies the '--stacked' flag, they can somewhat expect
> it will upgrade their branch.
> 
> Also, one could argue that LP shouldn't be telling the user to stack unless a
> project has decided it wants that feature.

One could, but I would strongly disagree.  Any branch host ought to be
able to take reasonable measures to improve storage efficiency, and I
believe stacking is such a measure.  Doing it on the client side means
that the client can choose to ignore stacking, but I think it's a
sensible default.

I have done my best to choose policy that is good for Bazaar, and Bazaar
code hosts, not just Launchpad.

Automatically changing the format is another deal, though.  We should
not lightly change formats.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIs3Dy0F+nu1YWqI0RAvC0AJ9ZhAap89M3E64WSz0BYaOtD+K6BgCfdI1o
kw9LToTMCSQ04O30X/9oxVU=
=vtSW
-----END PGP SIGNATURE-----