[RFC] Change to use 'merge_sort' for per-file-log
John Arbash Meinel
john at arbash-meinel.com
Fri Sep 19 14:55:01 BST 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Andrew Bennetts wrote:
> John Arbash Meinel wrote:
> [...]
>> Also, I have one more addendum, which works around issues with
>> GraphIndex.get_parent_map(lots_of_keys). Basically, by requesting keys in 1000
>> key "chunks", I avoid the "buffer_all" overhead, but also avoid some of the
>> extra bisection overhead (especially for smaller indexes.)
>
>
...
>
> So I think your change is a good idea: When repository.texts.get_parent_map is
> done with RPCs (and it will be soon), I expect your change will cut down on
> round trips a great deal. So it will help "bzr log FILE" times over the
> network.
>
> -Andrew.
So, you may be misunderstanding the direction this takes. Instead of issuing a
single request for 60,000 (file_id, revision_id) tuples, I make 60 requests
for 1,000. So I think this will potentially hurt remote performance. Except
for the "buffer all" issue. (When you have large indexes, *bandwidth* starts
to become as important as *latency*.)
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFI0681JdeBCYSNAAMRAh8qAKCKJGnTo4wzZ4b2ajKZXPhuCyIcaACgjd+F
skaUOU6fBWpZCkudeR5yqko=
=Pfij
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list