[MERGE][#295161] Ensure valid messages and revision properties

Jelmer Vernooij jelmer at ubuntu.com
Tue Nov 25 03:43:30 GMT 2008


Am Donnerstag, den 13.11.2008, 00:02 -0600 schrieb John Arbash Meinel:
> At the moment, we have a small issue with how we (de)serialize commit
> messages and revision properties because we go through XML.
> Specifically, when writing, we are allowed to write things like "\r" and
> "\r\n" to the string, but when those strings get read back, they will
> all be normalized to "\n". (This happens as part of the Expat parsing.)
> 
> This patch helps prevent those sorts of things being written to the
> repository, by checking the strings at commit time. I have an associated
> patch for bzr-gtk which sanitizes the messages before they get committed.
bb:approve

Cheers,

Jelmer
-- 
Jelmer Vernooij <jelmer at ubuntu.com> / https://launchpad.net/~jelmer/
IRC: jelmer / Jabber: jelmer at jabber.fsfe.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20081125/9558ba26/attachment.pgp 


More information about the bazaar mailing list