[MERGE] [#306424] Add trailing slash to directories in `bzr ls` output
John Arbash Meinel
john at arbash-meinel.com
Tue Dec 9 19:24:20 GMT 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Gordon P. Hemsley wrote:
> John,
>
> Adding symbols beyond the slash was not the intention of this patch. In
> my (brief) testing, no such situation occurred. Can you verify that you
> have generated output with this patch that includes symbols such as @ or
> *? Also, these changes pass all the unittests, once I change them to add
> slashes in the appropriate places. I didn't add any other symbols to
> those tests.
>
> Your concerns were already raised while I was discussing this on IRC. My
> intent was to have addressed them already. Apologies if I haven't.
>
> Let me know your results, then I'll make the appropriate changes.
>
> Thanks,
> Gordon
>
So I was wrong in my original evaluation. The "ie.kind_character()"
returns only '/' (for dirs) or '' (everything else).
I would still probably prefer the --null path to just return the dir
names without trailing slashes, but otherwise I believe I approve the patch.
Eventually I think --decorate would be nice to have, but this should at
least not break anything.
So I would like to see this part as it was:
elif null:
self.outf.write(fp + '\0')
if show_ids:
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkk+xeQACgkQJdeBCYSNAAMYJgCffyN4bbAI4vcnPqiIO+Chx/EN
YwMAn3cp1nFqUUkb7HA/+WfApfcm6VrA
=f2Gf
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list