[MERGE] Less bazaar coding style regressions.

Robert Collins robertc at robertcollins.net
Sat Dec 13 00:25:17 GMT 2008


On Sat, 2008-12-13 at 02:01 +0200, Marius Kruger wrote:


>         
>         +        bzr_dir =
>         osutils.dirname(osutils.realpath(sys.argv[0]))
>         
>         better as
>         bzr_dir = bzrlib.__path__[0]
> 
> I dont really aggree, since we want the workingtree containing the
> command being executed,
> but I changed it to 
> bzr_dir = osutils.dirname(bzrlib.__path__[0])

This gets the working tree of the bzrlib being tested; this is better
than the directory the command was run from because test runners may not
be in bzr at all!
 
Thanks for changing this,

bb:approve

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20081213/00b6f723/attachment.pgp 


More information about the bazaar mailing list