test_source harmful?

Ben Finney bignose+hates-spam at benfinney.id.au
Wed Feb 25 05:35:56 GMT 2009


Robert Collins <robert.collins at canonical.com> writes:

> The whitespace checks are really frustrating me;

I thought that was the point: to put the pain of fixing whitespace
mistakes squarely where they belong, at the point of the person
attempting to introduce them.

> I don't think we suffered anywhere near as much when occasional
> trailing whitespace existed as we do when merges are rejected [after
> a long test process]

Perhaps the checks on source should be done before running any tests
of functionality. Is that sequencing possible?

> solely because
> 
> def foo(self): 
>     """This is a docstring."""
> 
> I'd like to delete the test for source code formatting; unlike
> asserts trailing whitespace is not itself a bug.

Isn't the solution simply to configure your text editor to remove
trailing whitespace before you save the file?

-- 
 \     “I know you believe you understood what you think I said, but I |
  `\         am not sure you realize that what you heard is not what I |
_o__)                                     meant.” —Robert J. McCloskey |
Ben Finney




More information about the bazaar mailing list