[MERGE] Nested trees: misc

Robert Collins robert.collins at canonical.com
Tue Apr 7 21:48:46 BST 2009


On Tue, 2009-04-07 at 14:21 -0400, Aaron Bentley wrote:
> 
> +        subtree = tree.extract('subtree-id')
> +        tree._write_inventory(tree.inventory)
> +        tree.add_reference(subtree)

This is problematic - if you have to call _write_inventory externally to
use tree.extract() correctly, then we're making _write_inventory
de-facto public.

Is the _write_inventory call needed?

bb:comment
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090408/93f8ca9f/attachment.pgp 


More information about the bazaar mailing list