[MERGE] Nested trees: CompositeTree

Ian Clatworthy ian.clatworthy at canonical.com
Wed Apr 8 09:23:15 BST 2009


Ian Clatworthy has voted comment.
Status is now: Semi-approved
Comment:
I'm part way through reviewing this. All the modifications look fine to 
me. There are no tests for CompositeInventory - I gather the feeling is 
that it's being tested indirectly through CompositeTree. I'm OK with 
that but think it's worth renaming CompositeInventory to 
_CompositeInventory to reflect it's private-use status.

I'll complete the review tomorrow.

For details, see: 
http://bundlebuggy.aaronbentley.com/project/bzr/request/%3C49D4DE5C.8010100%40aaronbentley.com%3E
Project: Bazaar



More information about the bazaar mailing list