[MERGE] Handle tags when copying between repos during reconfigure.

Martin von Gagern Martin.vGagern at gmx.net
Thu Apr 23 16:06:13 BST 2009


Handle tags when copying between repos during reconfigure.

On IRC, lifeless stated that fetching the last revision is not enough to
fetch all information belonging to a branch, but that additional care
has to be taken for tags.

From http://irclogs.ubuntu.com/2009/04/23/%23bzr.html:
== 13:10 lifeless ==
> as long as the target bzrdir has no repository
> so 'add a repository to this branch which currently shares one' is:
> refs = branch.tags.get_tags.dict.keys() + branch.last_revision_id()
> repo = branch.repository._format.initialize(branch.bzrdir)
> for ref in refs:
>    repo.fetch(branch.repository, ref)
> fini
== 14:07 MvG ==
> lifeless: Up there you wrote "refs = branch.tags.get_tags.dict.keys()
> + branch.last_revision_id()" for importing. Why do you need the tags,
> shouldn't they all be ancestors of the last revision id?
== 14:33 lifeless ==
> MvG: no, they don't have to be

Though I don't fully understand the cause (as lifeless went away), and
haven't written a testcase exposing the problem, this modification
should address the issue.

Greetings,
 Martin von Gagern
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: fetch_branch-4298.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20090423/a31e7fc3/attachment-0001.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090423/a31e7fc3/attachment-0001.pgp 


More information about the bazaar mailing list