deleting InterDiffferingSerializer

John Arbash Meinel john at arbash-meinel.com
Tue May 5 04:40:09 BST 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


...

>> 4) Computing rich root information from the 'stream'. IIRC the
>> "Streaming" code does yet-another pass over the inventory data (I think
>> that makes 3) to determine the root-id and whether it has changed or not.
> 
> IDS does this too, and the delta based stream won't need to do that.
> 
>> So if you have the time to implement all of this for the streaming code,
>> by all means get rid of IDS. But it isn't like it is a trivial fix to
>> the smart fetch code to get it to provide all the benefits that we have
>> IDS for *today*. 1 bug is easily traded off the 4 benefits above, IMO.
>>
>> I fully agree that maintaining multiple code paths is crummy. But the
>> streaming code doesn't lend itself easily to most of the things I
>> described above.
>>
>> So -1 for just removing IDS, without addressing at least some of the above.
> 
> I think the key one is being able to stop and restart. While you say its
> important, I don't think its at all obvious to users how to do this: bzr
> branch old new preserves format unless they init a repo first; if they
> have done this, hitting ctrl-C will abort with no indicator that it is
> partial.
> 
> And our builtin 'upgrade' command is definitely not incremental.
> 
> Anyhow, I'll leave it alone at least until we have the deltas and other
> stuff in place; I'll bring up the issue again later.
> 
> -Rob

I did also forget a

5) Progress reporting. IDS gives you #/total num to copy. Last I
checked, the Stream code didn't have any progress reporting. (Which is a
bit bad for something that can take 2 days to finish.)

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEUEARECAAYFAkn/tRkACgkQJdeBCYSNAAMpNgCeNR7rAbDVCm37dCXC6lKWvMW6
YKkAli5bl2krVABjdmqmtHp+UXySpJI=
=Fp6P
-----END PGP SIGNATURE-----



More information about the bazaar mailing list