[MEGE] Fix some lock-related test failures (was Re: Testing and lock noise stipple.)

[Robert Collins]

On Fri, 2009-05-08 at 11:51 -0500, John Arbash Meinel wrote:
> 
> So it will probably fall into 'yet another unlock' case, but I'm not
> 100% sure. Certainly I believe 'x.leave_lock_in_place(); x.unlock()'
> is
> designed to *not* fix the physical lock, and the whole point is making
> sure that eventually the physical disk locks are getting cleaned up.

Right.

> Hmm.. thinking of it that way, it may be that 'leave_lock_in_place()'
> should actually be considered as a 'lock' request...

I think its better to just make sure there is a matching
thing.lock_write(token=foo)
thing.dont_leave_lock_in_place()
thing.unlock()

That will cleanup the physical lock.

-Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090509/ed9760e4/attachment.pgp