[MERGE] Bug 84659 "serve --allow-writes" allows more than you might think

[Danny van Heumen]

Hi,

My original message seems to be stuck in moderation, since I sent it
before subscribing to the mailinglist.

Danny

-------- Original Message --------
Subject: [MERGE] Bug 84659 "serve --allow-writes" allows more than you
might think
Date: Thu, 23 Jul 2009 20:14:23 +0200
From: Danny van Heumen <danny at dannyvanheumen.nl>
To: bazaar at lists.canonical.com

Hi,

Bug: https://bugs.launchpad.net/bzr/+bug/84659 (Tagged: Easy)

This bug is about the '--allow-writes' switch that also opens up the
server for anonymous writes, which is not immediately clear from the
name of the switch.

I've fixed this issue by adding a warning. In the case where
'--allow-writes' is called and '--inet' isn't, this warning will be
displayed.
The blackbox tests are fixed accordingly. (I'm assuming that we don't
need a separate test for testing just the warning message.)
(I've incorporated all the feedback Martin Pool gave me.)

Branch:
lp:~danny.vanheumen/bzr/84659-serve--allow-writes-allows-more-than-you-might-think


I hope that I'm doing everything right, since this is my very first code
contribution to bazaar (and using launchpad). So, please just let me
know if I do something wrong.

Kind regards,

Danny