RFC: make all inventories immutable except via deltas

[Jelmer Vernooij]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Robert Collins wrote:
> I wonder if we have enough support in our inventory delta code to:
> - make all InventoryEntries immutable - remove mutators on
> Inventory other than apply_delta
>
> This might make it easier to avoid aliasing and similar bugs with
> Inventory, and would make it possible for dirstate to keep its
> created inventory up to date too. (By having that inventory not
> have an apply_delta method - or having the apply_delta apply to the
> dirstate too).
Seems like a good idea.

Not all of the foreign vcs plugins would survive such a change at the
moment I suspect, but that shouldn't be too hard to fix.

Cheers,

Jelmer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iQIcBAEBCAAGBQJKb5m+AAoJEACAbyvXKaRXTTcP/jPAEpmyoc6OlWjxdsHuhUxM
/gnLXA+5i/Hw6v0efQ9HAST2lOp6OjOlSEDI89aK/PQhKIQt/vS0ZJghvN3qQwnd
a23klf7NyO4P4CEGtx1Pik3GYarbjy1eTgcKlGv1GQ+dLQmbAWhEgx5trPBdiBWd
IGcSo4kqaOgzlLGIMv+4T5tiPu79F2G6/Tj/kl5Ci6Pgo5AAeyJa48zyoWKQK9cB
o2Gjxaf3gWYU4Q69Q1cVE97fxydVsY4zuYQYCMoNvBQOMx3VcaHM8NXyVdMrPbBU
0yFVJCb8mm5yRdkZ9J4GJ/rkrZgPXhO+k0xF1z6zuMgqnqfxcbafP1cCrv967qSg
A67RIlt6O2HboyKjFHJ1yZRX93+dKfE/NFN/0qhcwLJXmUcYCS74f6kjCJoKuTrp
TPoDGO4gNbDOdgwkmurmHVx6gsCQsEiJRIcCMieWIO4fZpCySU7cN/bT0LLGzA2/
J3K+XqZ/YAKMyWhtF+JuFlmU88Nip0oBvwppZyoCa7GVwvhWdsKTSKfZxJmpkOj5
Js9++u1Xf4DpwiQ+FHhMGr2Bc2QBbOeGVzPMO+HLfQP29pHVBYA+boNR96RZllIj
1F8XW1pxTarUtzHoLHwsf5Jqi0mIzhPCog0c+yvhhQQqBP7tFqTFETjHqc0K2S7t
fCroDruWWvGnwB0Zvfzv
=9olD
-----END PGP SIGNATURE-----