[REGRESSION] bzr 1.17 does not use _knit_load_data compiled extension

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> 2009/7/28 John Arbash Meinel <john at arbash-meinel.com>:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Andrew Bennetts wrote:
>>> Andrew Bennetts wrote:
>>> [...]
>>>>> _knit_load_data_c was renamed to _knit_load_data_pyx by Vincent in bzr.dev
>>>>> revno 4472 but Vincent did not update all imports. At least not in 1.17.
> 
> I think this really shows a hole in our test coverage - to me the hole
> is more worrying than this particular failure, which as John says only
> affects quite old formats.  I filed
> https://bugs.edge.launchpad.net/bzr/+bug/406113 to track it.
> 
> There have been several cases where people have not been using the
> extensions or not been using the correct extensions and it causes
> confusing behaviour, or it causes them to see bzr as being slower than
> it can be.
> 

so I've written tests in the past that if X is available, then it is
used. And then if X is not available, we get a MissingFeature.

The issue is that PQM doesn't care about MissingFeature, partially
because it is mixed with PlatformDoesNotSupport.

I'm fine with having an explicit warning since I think we've evolved to
depend on these things. I'm concerned with:

1) Getting 10 warnings on every run when you don't compile any
extensions. It would be nice to have them aggregated. One possibility
would be to collect info about missing things, and report them as part
of the exit code. This also has the advantage of not intermixing signal
and noise. You get all the noise at once.

2) I think people would rather do "echo ignore_missing_extension=True"
>> ~/.bazaar/bazaar.conf, rather than setting an env var. Our config
code is unfortunate right now, because every check would need to re-read
the config file.

However, it would only be read when something is missing, so it
shouldn't impact runtime speed.

Though if we do (1) then the check can be done at a single time instead
of many times.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkpwd7AACgkQJdeBCYSNAAN1xgCgiQAv5qS/MGBk7eiOzrJF0B7P
4xsAn3Nxw7oYObUFm3W13UtbOqE3vJKb
=RpDM
-----END PGP SIGNATURE-----