[MERGE] DWIM revspecs
Jelmer Vernooij
jelmer at samba.org
Wed Sep 2 16:50:44 BST 2009
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Matthew D. Fuller wrote:
> On Sat, Jul 25, 2009 at 10:41:11AM -0500 I heard the voice of
> Matthew D. Fuller, and lo! it spake thus:
>> One additional reason merging it would fail would be that there
>> are some test failures I didn't clean up.
>>
>> I think the Rightest Answer is probably just to remove those bits
>> of testing. The reason is because they think they're testing bad
>> revno's, but with this change what they're ACTUALLY testing now
>> is something we can't find among the DWIM choices (which I'm
>> already testing in the TRS_dwim tests). I'm not quite certain of
>> the right thing to do, though, so I'd like some second opinions.
>
> Well, based on the extensive feedback received, I've gone ahead and
> eliminated some of these tests, and shuffled around others. There
> were some doctests this also required changes to; I'm not really
> sure if some of those shouldn't just be eliminated, since they
> don't add anything, but I'll let somebody else make that judgement
> call.
>
> In a full selftest run, this gives one new error in addition to the
> bunch I expect from my last full run attempt, but it's in
> blackbox.test_serve, so I'm pretty sure it doesn't have anything to
> do with this change.
Perhaps this is something that could wait for the next round of
patches, but it would be nice if it was possible to register new
"DWIM" probers. E.g. I'd be interested in registering a revision
specifier that supported git short SHAs.
Cheers,
Jelmer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10rc1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iQIcBAEBAgAGBQJKnpRUAAoJEACAbyvXKaRXIMQP/jLWvadqzlytRfTDjYTVzE1I
WUPDvskDosAh9/1mT0F7V9xLIVKueNylp2kV+KMiVjDktKH1tlsF8IDLq5INannQ
x8Bz5DViXjgFx8szo3bdEWIiXFz4czp0zoAdV5afv0flOxyhrvh+ErcJlbZhlSkk
PNhhFgl6Elcf3Gv5VEDDmxhAgGzC1C4VozRfRfRZ1yvAiOlGJaZ+C/gAYE7ibwhK
PU9W4cX5IMZTdiAVCY38czk9W6VU4eDmaW8H1EtgSTIfHuc0ljE7/i9HnkzwsZtW
c2rgKoKbZZojQtiDDo/NOPYp2oRmVbXecHAgpgM81Lf9pyWpQGWcRy28fdv/LxQY
6X+4HCrH/UVRwjwULBEKtKfLlQxb4PjVI5zoeBRxx/200XNvywg9EUHHWcY/TS+d
UtSNbF+XwKEjRoikHzft82rus16NHwsKMdsuWedVRIoaltQ//+6NlOaQ/djMzNJF
9ZjUGDJHyLJGYhSt0x3EzRhYHh4rT2Lri/IaS1V2z20t9Wjvy9TUzOsG0TDEVboE
Qoy4iKLuRM/kWxm9ewBGhQcWrdAaLRXWNgOqUFC4XbUGrTZWNxYlTTiseVgYExbU
VfbjYHtLP7q63ePwurO0HRqEaoN6LduTYjbBTLXhveJv3/B5F/P23ymC5xr5Kw2h
kfB52FMpJ6bdY7WCytFf
=PLwg
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list