Slow tests
Martin Pool
mbp at canonical.com
Fri Sep 18 01:12:25 BST 2009
2009/9/18 Harald Meland <harald.meland at usit.uio.no>:
> [Martin Pool]
>
>> 2009/9/18 Robert Collins <robertc at robertcollins.net>:
>>> Its handling of comments and docstrings that probably drove Martin's use
>>> of the AST. If we're not actually using the word assert anywhere, then
>>> I'd just be as simple [and fast:)] as possible.
>>
>> Yes, I used the AST so that it would be more correct, but this is an
>> unreasonably high price to pay for it. I think using a regexp is
>> fine, and if that means that we can't have the word 'assert' at the
>> start of a line in a docstring we'll live with it.
>
> The point I'm trying to make is that we can do both.
>
> I've proposed a merge of my current branch now; we can get back to the
> even faster (but less obviously correct) version if the test still is
> too slow after that.
I'm talking about a case like this:
"""Hi Harald, what happens with an
assert statement
on a line within a triple-quoted string?"""
You probably can write a regexp to match it, but I'm not sure it matters.
--
Martin <http://launchpad.net/~mbp/>
More information about the bazaar
mailing list