Slow tests
Martin Pool
mbp at canonical.com
Fri Sep 18 07:45:50 BST 2009
2009/9/18 Martin (gzlist) <gzlist at googlemail.com>:
> On 17/09/2009, Martin Pool <mbp at canonical.com> wrote:
>> 2009/9/18 Robert Collins <robertc at robertcollins.net>:
>>> Its handling of comments and docstrings that probably drove Martin's use
>>> of the AST. If we're not actually using the word assert anywhere, then
>>> I'd just be as simple [and fast:)] as possible.
>>
>> Yes, I used the AST so that it would be more correct, but this is an
>> unreasonably high price to pay for it. I think using a regexp is
>> fine, and if that means that we can't have the word 'assert' at the
>> start of a line in a docstring we'll live with it.
>
> Everyone else is running off on the grep route, but could also use the
> _ast module. That means Python 2.5 or later, but skipping the source
> checking tests on 2.4 wouldn't hurt much. Quick hack reveals it is
> somewhat faster:
Getting good coverage on python2.4 is desirable because our pqm runs
that. As long as we support using 2.4 it's probably good that pqm
should run it because nobody else does. If they're compatible I
suppose there's no harm using a faster one in 2.5+.
--
Martin <http://launchpad.net/~mbp/>
More information about the bazaar
mailing list