[RFC] Changing the generate_commit_message_template and commit_message_template hook APIs

[Robert Collins]

On Sat, 2009-09-12 at 03:09 +0200, Gary van der Merwe wrote:
> On Sat, Sep 12, 2009 at 12:53 AM, Robert Collins
> <robertc at robertcollins.net> wrote:
> > Why not just invoke tree.commit directly in qbzr?
> >
> > I don't see that a 'more clear' definition will help, if the template
> > code wants to derive data about the commit that /is happening/, unless
> > you are doing a commit, it will break.
> 
> Well, that's the difference. I want the template before we do the
> commit, when the dialogue gets opened.

This is intrinsically incompatible with templates that want to (e.g.)
show the files being committed.

Consider:
 - a plugin that automanages extra metadata (e.g. etckeeper). This
plugin will cause files that are not supplied to the commit command line
to be altered. (because its tracking additional permission bits)
 - the template code that shows 'these files are being modified by the
commit'

Without running the whole commit twice, I don't see how to reconcile
these two things :- and more complex example won't work even if you do
run it twice.

John says you're trying to solve a UI responsiveness issue? Is that so -
what's the issue, I'd like to help you solve it.

-Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090913/66158424/attachment.pgp