Patch Pilot report

[Ian Clatworthy]

Jonathan Lange wrote:
> On Mon, Nov 23, 2009 at 4:23 AM, Martin Pool <mbp at canonical.com> wrote:

>>> The thing I love about LP reviews is that it works so nicely across
>>> every project on LP. The thing I dislike about it is that BundleBuggy
>>> was a better queue manager for bzr core reviews.
> 
> I *think* this is because BundleBuggy encoded Bazaar-specific policy
> into its behaviour. I bet that someone could hack up a client-side
> thingy that would get you most of the way there.

Thanks for poolie for his in depth analysis.

I'll highlight just a few things that stand out for me:

1. We don't seem to have the right process for getting stuff off
   the list because it's not close to landing. In BB, the first
   reviewer would mark it as "Resubmit"[2] and then the queue for
   "reviews to look at" would be shorter for everyone. More broadly,
   BB made good use of tabs. The information about reviews that were
   in 'resubmit' state was available but not continually in your face.

2. "Size of change" information is missing in LP. For small lists
   (like the merge proposals for most plugins), it's a non-issue.
   For a list with 10 or more reviews pending, *I* like to knock
   off the smaller ones first (keeping the list size down and in
   control). The bigger reviews would take several hours so
   seeing the size would give me some indication before I started
   what commitment I was making by taking on a particular review.

Ian C.

[1] I guess the equivalent state in LP reviews is "Work in Progress".