Launchpad reviews (was Re: Patch Pilot report)

[Martin Pool]

Let me add a few more things:

The criticism is intended to be constructive; the page is already
quite useful but it has the germ of an amazing system.

The "wants review from/claim review" system is interesting, but not
fully realized.  It should be clear from the list "needs review from
me in particular", "needs review from someone on the team", "doesn't
need more reviewers".

When someone works on an mp the system should be asking them "what's
the next action?" much more clearly than at present.  The answers
could include:

 * I want John to review this
 * I want someone else from ~bzr to review this, I don't care who
 * I don't know what to do with it (maybe the same as the previous)
 * It just needs to be landed
 * I will do the changes and land it
 * I want someone to do the changes and land it, but not me
 * I want the submitter to do the changes and land it (not sure what
status this is)
 * I want the submitter to do the changes and resubmit it (I guess
this is 'needs fixing'?)
 * I need the submitter to do something other than to the code, eg to
sign the contributor agreement or confirm that they tested the
performance; nobody can progress this until then
 * I need to come back and finish reviewing it
 * We need to discuss and agree on whether this is even a good idea

These are kind of captured, but not optimally clearly or easily, and
they're not clearly displayed on the overview page.  (For instance
there is a bug about confusion between 'needs fixing', 'needs
information', 'approved' - I suspect when people cannot understand the
formal categories they leave it blank.)

-- 
Martin <http://launchpad.net/~mbp/>