Launchpad reviews (was Re: Patch Pilot report)

[Martin Pool]

2009/11/24 Robert Collins <robert.collins at canonical.com>:
> On Tue, 2009-11-24 at 12:30 +1100, Martin Pool wrote:
>> 2009/11/24 Gordon Tyler <gordon at doxxx.net>:
>> > Something else that has not been clear to me from the point of view of a
>> > contributor is when I should be resubmitting a merge proposal for which
>> > changes have had to be made since the initial proposal. Is there some
>> > threshold on the size of the subsequent changes above which the proposal
>> > should be resubmitted?
>>
>> I think that if you're not going to land it yourself, you should
>> always resubmit it when you update.
>
> As a reviewer, I hate this. It breaks the discussion, I have to refer to
> multiple places to see whats going on.

I think that's a flaw in the way superseded reviews work in general.
But I don't see any better way for the person to say they've done the
changes.  I suppose they can just comment and manually attach a diff.

> I'd pretty much love to see the 'resubmit' button deleted (until the
> fixes planned for it are completed).

-- 
Martin <http://launchpad.net/~mbp/>