'unshelve is slow'

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

https://bugs.edge.launchpad.net/bzr/+bug/599272

Hey Aaron-

We just had a comment about unshelve seeming to be very slow (taking 15s
or so). I had some analysis on it, and was wondering if it fits what you
know about unshelve (since you did 95+% of all the implementing and
follow up improvements.)

Basically, it looks like unshelve and PreviewTree.iter_changes() is
having to extract the entire Inventory, and that is being slow (5.2s to
compute iter_entries_by_dir() and 6.8s to compute _changes_from_entries()).

It also seems that PreviewTree.iter_changes() could make use of the
delta it generated as part of being serialized. (This may not be
directly straightforward, since I think you generate a serialized
transform, which may not directly correspond to an inventory delta.)

Do you have any thoughts on it?

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkwo7oIACgkQJdeBCYSNAAO/zwCff5e+tNacTh8IiPFap4sB0SSZ
OYcAoKPC+ROVD7u6PuYOL1GtLoCiXybE
=MGfZ
-----END PGP SIGNATURE-----