Test run on LP buildds - setup.py should not install Apport files

[Martin Pool]

On 13 October 2010 09:42, Max Bowsher <maxb at f2s.com> wrote:
> The first (to my knowledge) run of the bzr tests on the Launchpad
> buildds has completed in the bzr-beta-ppa. Good news - only one failure
> on 2.3b2.
>
> The single failure is:
>
> FAIL: test_setup.TestSetup.test_build_and_install
>
> and the cause appears to be:
>
> error: /usr/share/apport/package-hooks/source_bzr.py: Permission denied
>
>
> Which basically translates as the setup.py doing some rather dodgy
> special-casing of the apport hook installation in a way which is
> incompatible with being run under fakeroot.
>
> I could probably fudge around this in some way, but perhaps it's the
> impetus we need to make that particular bit of setup.py not be "a bit
> gross" (to quote the comment there).
>
> Personally, I think setup.py has absolutely no excuse to be installing
> files outside of a passed in --prefix argument.
>
> In fact, I'd suggest that setup.py shouldn't be installing the apport
> gubbins at all. Leave that up to the OS packager to get right. The hook
> is named after the Debian source package name, after all.

That was my code and I would be happy to see it gone.

There is a segment of users who might have apport installed but be
installing bzr from source, not from a package.  It would be kind of
nice to get full integration.  But this is probably not a large enough
number to justify the messy installation, and they can always just
directly attach the crash file.

So delete away!

You'll need to change that test too of course.

-- 
Martin