RFC: Initial branch operation order

John Arbash Meinel john at arbash-meinel.com
Wed Apr 27 07:20:13 UTC 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

At the moment, our code is a bit cluttered with fetch-like operations,
leading to bugs like:
 https://bugs.launchpad.net/bzr/+bug/771255

(initial branch doesn't copy tags)

I'm thinking about improving that a bit, but my idea goes against an old
design from Robert, that I'd like to talk through a bit.

Specifically, BzrDir.sprout() re-implements a lot of Branch.pull (except
now it doesn't have the tag-fetching code). At least a partial reason is
because Robert didn't want us to create a proper Branch at the target
until we had the revisions for it already copied into its Repository. So
people wouldn't see a new Branch that had no revisions (tip ==
'null:'),they would just see NoSuchBranch until the fetch finished.

The biggest reason for the change is that I think it would simplify the
model (you would always use InterBranch.get() for exchanging the
revisions, etc.)

Thoughts?

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk23w60ACgkQJdeBCYSNAAONQwCgpHi4TTQ+xjgRvPp+LS2Jp8g0
zi8AoMUhUY/04dyQ8q1KAM/d3d7z+fwA
=7nM1
-----END PGP SIGNATURE-----



More information about the bazaar mailing list