bzr status: hiding shelf info if files are specified
Eli Zaretskii
eliz at gnu.org
Fri Nov 18 07:11:30 UTC 2011
> From: Alexander Belchenko <bialix at ukr.net>
> Date: Thu, 17 Nov 2011 22:59:18 +0200
>
> Eli Zaretskii пишет:
> >> From: Francis Devereux <francis at devrx.org>
> >> Date: Thu, 17 Nov 2011 20:26:43 +0000
> >> Cc: bazaar at lists.canonical.com
> >>
> >> On 17 Nov 2011, at 20:18, Robert Collins wrote:
> >>
> >>> What about when the shelve has a patch for the file specified?
> >> With my current code the shelf message won't be shown in this case.
> >> Maybe we could scan the shelves looking to see whether any of them have a patch for the file specified, and if so print a message like "x shelves affect the files that you specified" or a letter (S?) next to the filenames themselves meaning "affected by shelves".
> >
> > Please don't make "bzr status" slower than absolutely necessary. I
> > think there's no particular reason why it should tell about shelves
> > even when the file has changes in one of the shelves, and doing so
> > would make the command slower.
>
> I agree. Not because it could be slower, but I don't think scanning
> shelf is so necessary.
Well, both. Doing unnecessary things in such a popular command means
unnecessarily slowing it down.
Both the slowdown and the change in the output format could have
unintended consequences. E.g., Emacs runs "bzr status" every time a
versioned file is visited or saved, so a slowdown will be noticed by
users who will complain, and a change in format might break the Emacs
code that parses it.
> Especially when there are several files specified in the command
> line. What if some files have patches on shelf, and some haven't?
> What bzr should print in such case? Things very quickly become very
> tricky. Let's keep it simple.
Right.
More information about the bazaar
mailing list