Review Board with a Bazaar repository

[Jelmer Vernooij]

Am 24/12/11 19:08, schrieb Benjamin Jansen:
> On Dec 24, 2011, at 01:25 , Jelmer Vernooij wrote:
>
>> On 12/24/2011 04:49 AM, Benjamin Jansen wrote:
>>> * Use the bzr-diff-revid plugin [1]
>> IIRC there was a drive to merge that into bzr core, did that ever happen?
> No. The consensus of those who commented was that it should be a plugin.
>
>>> * I suggest against using the bzr+http protocol to access your
>>> repository from RB. It's slow. We use file:// over NFS.
>> I think this slowness will be addressed by the upcoming beta 5 for bzr 2.5.
> Cool. Review Board's design is such that it must reopen to the branch for each file in the diff. IIRC, that was the most expensive operation while loading the diff. Is that part of what will be sped up?
>
Yes, there is now a dedicated call in the smart server protocol for 
retrieving the full contents of a particular versioned file, without 
having to read the various packs that contain deltas relevant for that file.

Cheers,

Jelmer