[Bug 11184] GNOME CD player crashes in the end of playing a CD

[bugzilla-daemon at bugzilla.ubuntu.com]

Please do not reply to this email.  You can add comments at
http://bugzilla.ubuntu.com/show_bug.cgi?id=11184
Ubuntu | gnome-media


seb128 at ubuntu.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From seb128 at ubuntu.com  2005-08-17 13:15 UTC -------
debdiff of the upload:

diff -u gnome-media-2.10.1/debian/changelog gnome-media-2.10.1/debian/changelog
--- gnome-media-2.10.1/debian/changelog
+++ gnome-media-2.10.1/debian/changelog
@@ -1,3 +1,10 @@
+gnome-media (2.10.1-0ubuntu1.1) hoary-updates; urgency=low
+
+  * gnome-cd/gst-cdparanoia-cdrom.c:
+    - don't hang after playing a CD (Ubuntu: #11184).
+
+ -- Sebastien Bacher <seb128 at canonical.com>  Wed, 17 Aug 2005 13:18:45 +0200
+
 gnome-media (2.10.1-0ubuntu1) hoary; urgency=low

   * New upstream version:
only in patch2:
unchanged:
--- gnome-media-2.10.1.orig/gnome-cd/gst-cdparanoia-cdrom.c
+++ gnome-media-2.10.1/gnome-cd/gst-cdparanoia-cdrom.c
@@ -205,6 +205,19 @@
            (GstCdparanoiaCDRomPrivate *) data;*/
 }

+static gboolean
+stop_playback_idle_func (gpointer data)
+{
+       GstCdparanoiaCDRomPrivate *priv =
+           (GstCdparanoiaCDRomPrivate *) data;
+
+       gst_element_set_state (GST_ELEMENT (priv->play_thread),
+                               GST_STATE_NULL);
+       priv->check_playtime = 0;
+
+       return FALSE;
+}
+
 static void
 check_playtime (GstBin * bin, gpointer data)
 {
@@ -219,9 +232,7 @@
            gst_pad_query (GST_PAD (priv->cdp_pad), GST_QUERY_POSITION,
                           &priv->sector_format, &value);
        if (ret && priv->check_playtime && value >= priv->end_playtime) {
-               gst_element_set_state (GST_ELEMENT (priv->play_thread),
-                                      GST_STATE_NULL);
-               priv->check_playtime = 0;
+               g_idle_add (stop_playback_idle_func, data);
        } else {
                for (i = 0; i < priv->number_tracks; i++) {
                        if (value <


-- 
Configure bugmail: http://bugzilla.ubuntu.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.