[Bug 15408] New: GDM init script magic and locale setting function

[bugzilla-daemon at bugzilla.ubuntu.com]

Please do not reply to this email.  You can add comments at
http://bugzilla.ubuntu.com/show_bug.cgi?id=15408
Ubuntu | gdm

           Summary: GDM init script magic and locale setting function
           Product: Ubuntu
           Version: unspecified
          Platform: i386
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdm
        AssignedTo: seb128 at ubuntu.com
        ReportedBy: fl at well.com
         QAContact: desktop-bugs at lists.ubuntu.com


hi,

found the following things in the /etc/init.d/gdm script. Package is gdm
2.8.0.4-0ubuntu5 i386 (though I suppose the script is the same for all
architectures...)

1) the first line says: "#! /bin/sh". That seems to be a space too much between
#! and /bin/sh ? Although it is valid to have the space, I just find it
uncommon. A little below, in line 12, "set -e" is done, which could also be as
an option in the first line. But again, rather a matter of taste.

2) in line 33,  LANG=$(/usr/sbin/pam_getenv -l LANG) is set with this command
substituion. Because -e is set, the script bails out when this substitution does
not work. If for some reason the call doesn't come back - the login manager does
not start. What do you think about setting the C locale, when the call fails?
like either not setting -e, or putting it in an if statement like

if [ -r /etc/environment ]; then
  if LANG=$(/usr/sbin/pam_getenv -l LANG); then
    export LANG
  else
    echo "LANG not found in /etc/environment, setting default locale"
    export LANG="C"
  fi
fi

regards
Florenz

-- 
Configure bugmail: http://bugzilla.ubuntu.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.