[Bug 22168] New: documents folder vendor patch causes segfaults

[bugzilla-daemon at bugzilla.ubuntu.com]

Please do not reply to this email.  You can add comments at
http://bugzilla.ubuntu.com/show_bug.cgi?id=22168
Ubuntu | libgtk2.0-0

           Summary: documents folder vendor patch causes segfaults
           Product: Ubuntu
           Version: unspecified
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libgtk2.0-0
        AssignedTo: seb128 at ubuntu.com
        ReportedBy: desrt at desrt.ca
         QAContact: desktop-bugs at lists.ubuntu.com


a vendor patch introduced in 2.8.9-2ubuntu1 is causing big problems.

i'll spare you the stacktrace.

gtkfilesystemunix.c (get_icon_name_for_directory)

  static char *documents_path = NULL;

[...]

  if (!documents_path)
    {
      default_documents_path = g_build_filename (g_get_home_dir (), "Documents",
NULL);
      if (g_file_test (default_documents_path, G_FILE_TEST_IS_DIR))
          documents_path = g_strdup (default_documents_path);
      g_free (default_documents_path);
    }

/* XXX notice that documents_path may still very well be NULL here XXX */

  if (strcmp (g_get_home_dir (), path) == 0)
    return "gnome-fs-home";
  else if (strcmp (desktop_path, path) == 0) /* call strcmp() with a NULL
argument :( */


This entire patch looks a bit weird.  Why does it strdup just to immediately
free the original?

-- 
Configure bugmail: http://bugzilla.ubuntu.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.