[Bug 22168] documents folder vendor patch causes segfaults

[bugzilla-daemon at bugzilla.ubuntu.com]

Please do not reply to this email.  You can add comments at
http://bugzilla.ubuntu.com/show_bug.cgi?id=22168
Ubuntu | libgtk2.0-0





------- Additional Comments From desrt at desrt.ca  2006-01-09 07:21 UTC -------
Created an attachment (id=5618)
 --> (http://bugzilla.ubuntu.com/attachment.cgi?id=5618&action=view)
an updated version of the offending patch

Here's a new copy of the patch that works a lot better for me.

It does the same thing with the documents folder as upstream GTK does for the
desktop.  This has a number of advantages with respect to the previous
approach:

- you're guaranteed a non-null value (no crash)
- you only do it once (instead of re-computing + failing every single time this
function gets called -- each attempt in the old patch is several memory
allocations/frees and a syscall.)
- no stat required at all in the new patch.  if the directory isn't there then
you won't be asking about what icon it should have and therefore nobody cares.
- more simple.

cheers.

-- 
Configure bugmail: http://bugzilla.ubuntu.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.