[Bug 39024] Re: [Dapper] Gedit fails to save to remote location if creating new file while using sftp

[Ryan Lortie]

The problem is caused by iobuf_read_file_info() in the gnome-vfs sftp
method.

        if (id != expected_id || type != SSH2_FXP_ATTRS) {
                buffer_free (&msg);
                return GNOME_VFS_ERROR_PROTOCOL_ERROR;
        }
        else if (type == SSH2_FXP_STATUS) {
                gnome_vfs_file_info_clear (info);
                status = buffer_read_gint32 (&msg);
                buffer_free (&msg);
                return sftp_status_to_vfs_result (status);
        }

Notice that it's actually impossible for the (type == SSH2_FXP_STATUS)
to ever be true and that in this case the PROTOCOL_ERROR is incorrectly
returned.

I've written a patch to move the order of the code around to the logical
order.  The patch fixes the problem.

** Changed in: gedit (Ubuntu)
       Status: Needs Info => Rejected

** Also affects: gnome-vfs2 (Ubuntu)
     Severity: Normal
     Priority: (none set)
       Status: Unconfirmed

** Changed in: gnome-vfs2 (Ubuntu)
       Status: Unconfirmed => In Progress

-- 
[Dapper] Gedit fails to save to remote location if creating new file while using sftp
https://launchpad.net/bugs/39024