ubuntu-image 0.7ubuntu1

[Oliver Grawert]

hi,
On Di, 2016-10-11 at 10:54 -0700, Steve Langasek wrote:
> 
> So I would suggest:
> 
>  - a --size option to ubuntu-image to specify the full image size
> (needs
>    some careful thought for the multiple-image case)

just default to the minimal size as long as it is not set, beyond this
i really don't care if its a "fudge factor" or the final image size
that i define as long as i can define something at all (and yes, this
will surely be in the gigabytes) 

>  - keep the 50% buffer on ext4 filesystem size as a floor (the '50%'
> can be
>    refined over time with investigation into the actual size
> requirements
>    for ext4 metadata, but this is not a high priority; highest
> priority is
>    that it works reliably)

where does this massively high value come from ? 10% seems to make some
sense in case the resizing fails or some such and you still want some
space to be able to debug. but i think 50% is absolutely excessive here
(we are wasting 300MB for a minimal size built image on the downloaders
disk for no good reason).

>  - if --size is smaller than the minimum size needed to accommodate
> the
>    contents, warn but build the image anyway - because all the
> expensive
>    work of ubuntu-image happens /before/ we're able to calculate the
> final
>    size, so throwing that all away at the end would be /very
> annoying/.
> 

why not just fall back to the minimal size ? we obviously know it will
be to small and have actual data for doing the comparison so just print
a warning like: 

"picked size will not fit, falling back to minimal size"

and build with the minimal size that we have computed already.

ciao
	oli
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part
URL: <https://lists.snapcraft.io/archives/devices/attachments/20161011/669da7bc/attachment.pgp>