[Bug 798333] Re: Timestamp incorrectly calculated for timezones with minute offset

[Bug Watch Updater]

Launchpad has imported 3 comments from the remote bug at
http://bugzilla.adiscon.com/show_bug.cgi?id=271.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2011-06-16T15:13:09+00:00 Ed Swierk wrote:

If you run rsyslog with $ActionFileDefaultTemplate set to
RSYSLOG_FileFormat and set the system timezone to Australia/Adelaide,
log messages incorrectly show the offset as +09:08 rather than +09:30.

getCurrTime() in datetime.c tries to convert the timezone offset in
seconds (lBias) to OffsetHour and OffsetMinutes:

  t->OffsetHour = lBias / 3600;
  t->OffsetMinute = lBias % 3600;

lBias % 3600 gives the remainder in seconds, not minutes.  Since
OffsetMinute is a char, the result is effectively (lBias % 3600) % 256,
which happens to be 8 in the case of the Australia/Adelaide timezone.

To fix this bug the second line should instead read:

  t->OffsetMinute = (lBias % 3600) / 60;

Reply at: https://bugs.launchpad.net/rsyslog/+bug/798333/comments/0

------------------------------------------------------------------------
On 2011-06-16T15:30:43+00:00 Rgerhards-j wrote:

confirmed as far back as v3 (earlier versions not checked)

Reply at: https://bugs.launchpad.net/rsyslog/+bug/798333/comments/1

------------------------------------------------------------------------
On 2011-06-16T16:27:25+00:00 Rgerhards-j wrote:

fixed in 3.22.4, 4.6.6, 5.8.2, 5.9.1. Fix for v6 with next merge (which
is a large task to do).

"Official" patch here:

http://git.adiscon.com/?p=rsyslog.git;a=commitdiff;h=da52cbae520e747568162ad558bf01d40658c745

Thanks for the bug report and analysis!

Reply at: https://bugs.launchpad.net/rsyslog/+bug/798333/comments/2


** Changed in: rsyslog
       Status: Unknown => Fix Released

** Changed in: rsyslog
   Importance: Unknown => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to rsyslog in Ubuntu.
https://bugs.launchpad.net/bugs/798333

Title:
  Timestamp incorrectly calculated for timezones with minute offset

Status in Rsyslog:
  Fix Released
Status in “rsyslog” package in Ubuntu:
  New

Bug description:
  Binary package hint: rsyslog

  If you run rsyslog with $ActionFileDefaultTemplate set to
  RSYSLOG_FileFormat and set the system timezone to Australia/Adelaide,
  log messages incorrectly show the offset as +09:08 rather than +09:30.

  Affects all versions of rsyslog in oneiric, natty, maverick, and
  lucid. Fixed upstream.

  http://bugzilla.adiscon.com/show_bug.cgi?id=271

To manage notifications about this bug go to:
https://bugs.launchpad.net/rsyslog/+bug/798333/+subscriptions