[Bug 745638] Re: Cancelling sign-in after grading review says "Submitting now…" forever

[Aaron Peachey]

Hi mpt, this makes sense and we should be able to make the links
insensitive while the dialog is up.

My only issue is when a 'silent' sign in is happening because the user
has already entered their credentials and the sign-in is just the app
using the token to sign in with the server. This happens without UI and
can take a couple of seconds, I'm not sure about insensitive buttons
while that's happening.

Essentially we have four 'states' when submitting a vote:
1. Signing in, dialog visible, waiting for user input.
2. Signing in, dialog visible, user input received and signing in with server
3. Signing in, no dialog visible, authenticating with server
4. Submitting vote, no dialog visible

Case 1: User has previously signed in 
Then we have state (3) for a couple of seconds and then state (4). 
My personal opinion is that a spinner should be visible on the review on the app details screen for both states 2 and 3 in this case, since the user is waiting for the computer to negotiate the vote.

Case 2: User has not previously signed in (or has no account or is unauthenticated for some reason) 
Then we have state (3) temporarily (while we try to sign in, and figure out we need user input) then state (1) for a period of time while the user enters their input then state (2) actually signing in and then state (4).

So, in case 1 we should display the spinner during both states. Perhaps
the text of the spinner should say 'signing in' during state 3 and
'submitting now' during state 4.

In case 2, we may need some thought, as this seems clunky to me:
State (3)  - Spinner running, "signing in"
State (1) - Spinner stopped, "awaiting sign in details" (Alternative: Normal usefulness UI visible, Yes/No links insensitive)
State (2) - Spinner running, "signing in"
State (4) - Spinner running, "submitting now"

To qualify all of this, I'm not certain about what level of signalling
we currently havefrom the submit_usefulness helper so all this UI
changing may not be a quick fix, but should be possible with some
tweaks.

Any thoughts?

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to software-center in Ubuntu.
https://bugs.launchpad.net/bugs/745638

Title:
  Cancelling sign-in after grading review says "Submitting now…" forever

Status in “software-center” package in Ubuntu:
  In Progress

Bug description:
  Ubuntu Software Centre 3.1.24.3, Ubuntu Natty daily 20110327
  software-center-gtk3 trunk r2169, Ubuntu Ocelot

  0. In a new user account, launch USC.
  1. Find a software review.
  2. Next to "Was this review helpful?" click "Yes" or "No".
  3. In the sign-in dialog, click "Cancel".

  What happens:
  2. A spinner and "Submitting now…" appears.
  3. The spinner and text remain.

  What should happen: The spinner and "Submitting now…" text don't
  appear until you've signed in.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-center/+bug/745638/+subscriptions