[Bug 793694] Re: Format string bug in parselog.pl

[Serge Hallyn]

Thanks for taking the time to submit this bug report and helping to make
Ubuntu better.

I can reproduce this in oneiric, as well as confirm that your proposed fix works.
---
Ubuntu Bug Squad volunteer triager
http://wiki.ubuntu.com/BugSquad


** Changed in: samba (Ubuntu)
       Status: New => Confirmed

** Changed in: samba (Ubuntu)
   Importance: Undecided => High

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to samba in Ubuntu.
https://bugs.launchpad.net/bugs/793694

Title:
  Format string bug in parselog.pl

Status in “samba” package in Ubuntu:
  Confirmed

Bug description:
  Binary package hint: samba-doc

  samba-doc/examples/scripts/eventlog/parselog.pl have format string bug
  .

  test case :
  emanuel at amd64 /tmp>>echo '1 1 1 %n' | perl /usr/share/doc/samba-doc/examples/scripts/eventlog/parselog.pl
  Modification of a read-only value attempted at /usr/share/doc/samba-doc/examples/scripts/eventlog/parselog.pl line 30, <> line 1.
  emanuel at amd64 /tmp>>echo '1 1 1 1 %n' | perl /usr/share/doc/samba-doc/examples/scripts/eventlog/parselog.pl
  Modification of a read-only value attempted at /usr/share/doc/samba-doc/examples/scripts/eventlog/parselog.pl line 30, <> line 1.

  the bug can be found at :
      $outstr = sprintf "TMG: %d\nTMW: %d\nEID: 1000\nETP: INFO\nECT: 0\nRS2: 0\nCRN: 0\nUSL: 0\nSRC: Syslog\nSRN: $cname\nSTR: $ln\nDAT:\n\n",time(),time();

  fix : use %s to $cname and $ln .
  $outstr = sprintf "TMG: %d\nTMW: %d\nEID: 1000\nETP: INFO\nECT: 0\nRS2: 0\nCRN: 0\nUSL: 0\nSRC: Syslog\nSRN: %s\nSTR: %s\nDAT:\n\n",time(),time(),$cname,$ln;