[Bug 691558] Re: bzr ci -i crashes on binary files

[Jelmer Vernooij]

** Project changed: bzr => bzr-interactive

** No longer affects: bzr (Ubuntu)

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to bzr in Ubuntu.
https://bugs.launchpad.net/bugs/691558

Title:
  bzr ci -i crashes on binary files

Status in Bazaar Interactive plugin:
  Confirmed

Bug description:
  Binary package hint: bzr

  I commit with -i to interactively select which parts to put in the changset.
  Unfortunately this does not work with binary files.

  Darcs just asks if I want to commit a change to a binary file. Perhaps
  bzr could do the same?

  ProblemType: Crash
  DistroRelease: Ubuntu 10.10
  Package: bzr 2.2.1-0ubuntu1
  ProcVersionSignature: Ubuntu 2.6.35-24.42-generic 2.6.35.8
  Uname: Linux 2.6.35-24-generic x86_64
  NonfreeKernelModules: vmblock vsock vmci vmhgfs
  Architecture: amd64
  BzrDebugFlags: set()
  BzrVersion: 2.2.1
  CommandLine: ['/usr/bin/bzr', 'ci', '-i']
  CrashDb: bzr
  Date: Fri Dec 17 14:46:13 2010
  ExecutablePath: /usr/bin/bzr
  FileSystemEncoding: UTF-8
  InstallationMedia: Ubuntu 10.10 "Maverick Meerkat" - Release Candidate amd64 (20100928)
  InterpreterPath: /usr/bin/python2.6
  Locale: pl_PL.utf8
  Platform: Linux-2.6.35-24-generic-x86_64-with-Ubuntu-10.10-maverick
  ProcCmdline: /usr/bin/python /usr/bin/bzr ci -i
  ProcEnviron:
   SHELL=/bin/bash
   PATH=(custom, user)
   LANG=pl_PL.utf8
  PythonVersion: 2.6.6
  SourcePackage: bzr
  Title: bzr crashed with AttributeError in __init__()
  UserEncoding: UTF-8
  UserGroups: adm admin cdrom dialout lpadmin plugdev sambashare

  Traceback (most recent call last):
    File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 912, in exception_to_return_code
      return the_callable(*args, **kwargs)
    File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 1112, in run_bzr
      ret = run(*run_argv)
    File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 690, in run_argv_aliases
      return self.run(**all_cmd_args)
    File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 705, in run
      return self._operation.run_simple(*args, **kwargs)
    File "/usr/lib/python2.6/dist-packages/bzrlib/cleanup.py", line 135, in run_simple
      self.cleanups, self.func, *args, **kwargs)
    File "/usr/lib/python2.6/dist-packages/bzrlib/cleanup.py", line 165, in _do_with_cleanups
      result = func(*args, **kwargs)
    File "/home/username/.bazaar/plugins/interactive/__init__.py", line 105, in run
      to_commit, to_keep = RecordPatchHunkSelector(patches).select()
    File "/home/username/.bazaar/plugins/interactive/hunk_selector.py", line 203, in __init__
      HunkSelector.__init__(self, patches, color)
    File "/home/username/.bazaar/plugins/interactive/hunk_selector.py", line 80, in __init__
      for hunk in patch.hunks:
  AttributeError: 'BinaryPatch' object has no attribute 'hunks'

To manage notifications about this bug go to:
https://bugs.launchpad.net/bzr-interactive/+bug/691558/+subscriptions