[Bug 854841] Re: add-apt-repository will write duplicate entries to /etc/apt/sources.list

[Nick Russo]

I found that add-apt-repository calls

 SoftwareProperties().add_source_from_line(line)

In /usr/share/pyshared/softwareproperties/SoftwareProperties.py I found

 self.sourceslist.list.append(new_deb_entry)
 self.sourceslist.list.append(new_debsrc_entry)

I think it would be better to call self.sourceslist.add(), since it avoids
duplicates. The add() function requires more arguments, but the only ones
I had to hard-code were elsewhere in SoftwareProperties.py anyway.

I've included a patch (against 0.80.9 through 0.82) which seems to make thing
work nicely. I hard-coded deb, deb-src, and main.

** Patch added: "patch to SoftwareProperties.py to make add_source_from_line idempotent"
   https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/854841/+attachment/2611651/+files/SoftwareProperties.py.diff

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to software-properties in Ubuntu.
https://bugs.launchpad.net/bugs/854841

Title:
  add-apt-repository will write duplicate entries to
  /etc/apt/sources.list

Status in “software-properties” package in Ubuntu:
  Triaged

Bug description:
  Hello,
  Add-apt-repository command allows one to add duplicate entries to sources list. Would it be possible to improve this utility it so it adds only unique entries?

  Eg. This command, when run twice, adds duplicate entries.
  $ sudo add-apt-repository "deb http://archive.canonical.com/ubuntu oneiric partner

  $ grep -Ri partner /etc/apt/sources.list

  ProblemType: BugDistroRelease: Ubuntu 11.10
  Package: python-software-properties 0.81.9
  ProcVersionSignature: Ubuntu 3.0.0-11.18-generic 3.0.4
  Uname: Linux 3.0.0-11-generic x86_64
  NonfreeKernelModules: nvidia
  ApportVersion: 1.23-0ubuntu1
  Architecture: amd64
  Date: Tue Sep 20 18:38:17 2011
  InstallationMedia: Ubuntu 11.10 "Oneiric Ocelot" - Beta amd64 (20110919)
  PackageArchitecture: all
  ProcEnviron:
   PATH=(custom, no user)
   LANG=en_US.UTF-8
   SHELL=/bin/bashSourcePackage: software-properties
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/854841/+subscriptions