[Bug 663455] Re: Incorrect text found in openssh-client/auth-file.c:542

[Bug Watch Updater]

Launchpad has imported 3 comments from the remote bug at
https://bugzilla.mindrot.org/show_bug.cgi?id=1878.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2011-03-14T10:18:11+00:00 Colin Watson wrote:

David Lublink reported the following as an Ubuntu bug:

int
key_perm_ok(int fd, const char *filename)
{
[...]
          error("Permissions 0%3.3o for '%s' are too open.",
              (u_int)st.st_mode & 0777, filename);
          error("It is recommended that your private key files are NOT accessible by others.");
          error("This private key will be ignored.");
          return 0;
     }
     return 1;
}

The text "It is recommended that your private key files are NOT
accessible by others." should read "It is not permitted....".

There is no workaround to use a non-protected private key, therefore it
is incorrect to say "recommended".

Reply at: https://bugs.launchpad.net/openssh/+bug/663455/comments/4

------------------------------------------------------------------------
On 2011-04-12T05:39:54+00:00 Djm wrote:

patch applied - thanks

Reply at: https://bugs.launchpad.net/openssh/+bug/663455/comments/6

------------------------------------------------------------------------
On 2011-09-06T05:32:56+00:00 Djm wrote:

close resolved bugs now that openssh-5.9 has been released

Reply at: https://bugs.launchpad.net/openssh/+bug/663455/comments/7


** Changed in: openssh
       Status: Unknown => Fix Released

** Changed in: openssh
   Importance: Unknown => Low

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to openssh in Ubuntu.
https://bugs.launchpad.net/bugs/663455

Title:
  Incorrect text found in openssh-client/auth-file.c:542

Status in Portable OpenSSH:
  Fix Released
Status in “openssh” package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: metacity

  install the openssh-client source code, look at auth-file.c and see
  this stanza :

  int
  key_perm_ok(int fd, const char *filename)
  {
       struct stat st;

       if (fstat(fd, &st) < 0)
            return 0;
       /*
        * if a key owned by the user is accessed, then we check the
        * permissions of the file. if the key owned by a different user,
        * then we don't care.
        */
  #ifdef HAVE_CYGWIN
       if (check_ntsec(filename))
  #endif
       if ((st.st_uid == getuid()) && (st.st_mode & 077) != 0) {
            error("@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@");
            error("@         WARNING: UNPROTECTED PRIVATE KEY FILE!          @");
            error("@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@");
            error("Permissions 0%3.3o for '%s' are too open.",
                (u_int)st.st_mode & 0777, filename);
            error("It is recommended that your private key files are NOT accessible by others.");
            error("This private key will be ignored.");
            return 0;
       }
       return 1;
  }

  
  The text "It is recommended that your private key files are NOT accessible by others." should read "It is not permitted....".

  There is no work around to use a non-protected private key, therefore
  it is incorrect to say recommend.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openssh/+bug/663455/+subscriptions