[Bug 838720] Re: Crash on folder name with spaces

[Sérgio Faria]

Sylvain, this package is small so your diff shouldn't be a problem but
when using diff directly its a good practice that all +++ lines, which
are like metadata about where to apply the patch, contain the same name
as the originals with a relative path 1 level higher than the package
tree, specially when the diff patchesmore than one file.

So it gets like this:
--- iso-scan.orig/debian/iso-scan.postinst
+++ iso-scan/debian/iso-scan.postinst

And the dev, just needs to cd $PACKAGE; patch -p1 < patchfile instead of
patch originalfile patchfile

I'm not sure why I had doubts in #1 but this bug does affect debian too and its just that line (I thought there were 2...). 
I'll open a bug upstream.

Optionally, If you want, you can fix it directly by purposing a merge to
the branch lp:~ubuntu-core-dev/iso-scan/ubuntu using the procedure
mentioned in https://wiki.ubuntu.com/Bugs/HowToFix

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to iso-scan in Ubuntu.
https://bugs.launchpad.net/bugs/838720

Title:
  Crash on folder name with spaces

Status in “iso-scan” package in Ubuntu:
  Confirmed

Bug description:
  When installing oneiric alpha 3 with the hd-media image, the iso-scan
  udeb is searching for an iso on a disk but if a folder name contains
  spaces, (ie: Documents and Settings) an error occurs and the search
  stops.

  my setup:
  booting from usb disk /dev/sdb1 on system with one local disk and one usb disk

  /dev/sda1 (Win 7)
  /dev/sda2 (/boot)
  /dev/sda3 (lvm)
  /dev/sda4 (lvm)
  /dev/sdb1 (install image with preseed)


  I am not sure of the correct way to fix this but I find that changing line number 162 of the var/lib/dpkg/info/iso-scan.postinst file 
  from 
  isolist=$(find $dir $opt -name "*.iso" -o -name "*.ISO" 2>/dev/null)
  to
  isolist=$(find "$dir" $opt -name "*.iso" -o -name "*.ISO" 2>/dev/null)
  fixes the problem on my system

  The installer boot image I am using is from 
  archive.ubuntu.com/ubuntu/dists/oneiric/main/installer-amd64/current/images/hd-media/
  and as of today, the udeb.list file says that the package version of iso-scan is 1.35ubuntu1

  Note that this is my first bug report so I am not sure how to create a proper patch attachment
  Thanks, Sylvain

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iso-scan/+bug/838720/+subscriptions