[Bug 672643] Re: make test fails on xfs filesystem

[Ubuntu Foundations Team Bug Bot]

The attachment "change detection of directory to lstat() and extend
test_file to cover this case" of this bug report has been identified as
being a patch.  The ubuntu-reviewers team has been subscribed to the bug
report so that they can review the patch.  In the event that this is in
fact not a patch you can resolve this situation by removing the tag
'patch' from the bug report and editing the attachment so that it is not
flagged as a patch.  Additionally, if you are member of the ubuntu-
reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by
Brian Murray.  Please contact him regarding any issues with the action
taken in this bug report.]

** Tags added: patch

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to libnih in Ubuntu.
https://bugs.launchpad.net/bugs/672643

Title:
  make test fails on xfs filesystem

Status in NIH Utility Library:
  Triaged
Status in “libnih” package in Ubuntu:
  New
Status in “upstart” package in Fedora:
  Unknown

Bug description:
  If there is used xfs fs on /tmp, upstart make check fails on:
  BAD: wrong value for block file, got unexpected NULL
          at tests/test_conf.c:244 (test_source_reload_job_dir).

  It's because in libnih library there is a test if an entity is a directory based on struct dirent returned by
  readdir(3):

  nih/file.c:644      if (filter && filter (data, subpath, ent->d_type ==
  DT_DIR))

  but used item d_type is not supported by all filesystem like xfs,
  reiserfs and so on.

To manage notifications about this bug go to:
https://bugs.launchpad.net/libnih/+bug/672643/+subscriptions